Skip to content

Commit

Permalink
[Fix #742] Jean Baptiste comments
Browse files Browse the repository at this point in the history
  • Loading branch information
fjtirado committed Mar 11, 2024
1 parent 0e9e9cb commit b9f4b93
Show file tree
Hide file tree
Showing 13 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion examples/book-lending.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "booklending",
"name": "book-lending",
"description": "Book Lending Workflow",
"version": "1.0.0",
"specVersion": "0.8",
Expand Down
2 changes: 1 addition & 1 deletion examples/car-vitals-checks-subflow.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "vitalscheck",
"name": "vitals-check",
"description": "Car Vitals Check",
"version": "1.0.0",
"specVersion": "0.8",
Expand Down
2 changes: 1 addition & 1 deletion examples/car-vitals-checks.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "checkcarvitals",
"name": "check-car-vitals",
"description": "Check Car Vitals Workflow",
"version": "1.0.0",
"specVersion": "0.8",
Expand Down
2 changes: 1 addition & 1 deletion examples/continuing-as-a-new-execution.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "notifycustomerworkflow",
"name": "notify-customer-workflow",
"description": "Notify Customer",
"version": "1.0.0",
"specVersion": "0.8",
Expand Down
2 changes: 1 addition & 1 deletion examples/filling-a-glass-of-water.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "fillglassofwater",
"name": "fill-glass-of-water",
"description": "Fill glass of water workflow",
"version": "1.0.0",
"specVersion": "0.8",
Expand Down
2 changes: 1 addition & 1 deletion examples/monitor-job.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"version": "1.0.0",
"specVersion": "0.8",
"name": "jobmonitoring",
"name": "job-monitoring",
"description": "Monitor finished execution of a submitted job",
"start": "submit-job",
"functions": [
Expand Down
2 changes: 1 addition & 1 deletion examples/new-patient-onboarding.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "patientonboarding",
"name": "patient-onboarding",
"version": "1.0.0",
"specVersion": "0.8",
"start": "onboard",
Expand Down
2 changes: 1 addition & 1 deletion examples/perform-customer-credit-check.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"version": "1.0.0",
"specVersion": "0.8",
"name": "customercreditcheck",
"name": "customer-credit-check",
"description": "Perform Customer Credit Check",
"start": "check-credit",
"functions": [
Expand Down
2 changes: 1 addition & 1 deletion examples/process-transactions.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "customerbankingtransactions",
"name": "customer-banking-transactions",
"description": "Customer Banking Transactions Workflow",
"version": "1.0.0",
"specVersion": "0.8",
Expand Down
2 changes: 1 addition & 1 deletion examples/reusing-function-and-event-definitions.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"version": "1.0.0",
"specVersion": "0.8",
"name": "paymentconfirmation",
"name": "payment-confirmation",
"description": "Performs Payment Confirmation",
"functions": "file://functiondefs.json",
"events": "file://eventdefs.yml",
Expand Down
2 changes: 1 addition & 1 deletion examples/send-cloudevent-on-workflow-completion.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"version": "1.0.0",
"specVersion": "0.8",
"name": "sendcloudeventonprovision",
"name": "send-cloudevent-provision",
"start": "provision-orders-state",
"events": [
{
Expand Down
2 changes: 1 addition & 1 deletion examples/solving-math-problems.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"version": "1.0.0",
"specVersion": "0.8",
"name": "solve-math-problems-workflow",
"name": "solve-math-problems",
"description": "Solve math problems",
"start": "solve",
"functions": [
Expand Down
10 changes: 5 additions & 5 deletions specification.md
Original file line number Diff line number Diff line change
Expand Up @@ -4194,7 +4194,7 @@ This short-hand definition can be used if sub-workflow lookup is done only by it
property and not its `version` property.

```json
"subFlowRef": "mySubFlowName"
"subFlowRef": "my-subflow-id"
```

If you need to define the `version` properties, you can use its `object` type:
Expand All @@ -4219,7 +4219,7 @@ If you need to define the `version` properties, you can use its `object` type:

```json
{
"workflowId": "handleApprovedVisaWorkflowID",
"workflowId": "handle-approved-visa",
"version": "2.0.0"
}
```
Expand All @@ -4228,7 +4228,7 @@ If you need to define the `version` properties, you can use its `object` type:
<td valign="top">

```yaml
workflowId: handleApprovedVisaWorkflowID
workflowId: handle-approved-visa
version: '2.0.0'
```

Expand Down Expand Up @@ -6107,13 +6107,13 @@ If string type, it contains the unique workflow name of the workflow that the ex
```json
{
"end": {
"continueAs": "myworkflowname"
"continueAs": "my-workflow-name"
}
}
```

Defining this should stop the current workflow execution, and continue execution as a new workflow instance of the
workflow which defines the workflow name of "myworkflowbane". The state data where this is define should
workflow which defines the workflow name of "my-workflow-name". The state data where this is define should
become the workflow data input of the workflow that is continuing the current workflow execution.

Note that any defined `produceEvents` and `compensate` definitions should be honored before `continueAs` is applied.
Expand Down

0 comments on commit b9f4b93

Please sign in to comment.