New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integer overflow/wraparound in \src\mp4track.cpp #167

Open

GoogleCodeExporter opened this issue Oct 4, 2015 · 0 comments

Labels

auto-migrated Priority-Medium Type-Defect

Contributor

GoogleCodeExporter commented Oct 4, 2015

In line 1124: if (d <= sampleCount * sampleDelta), there is a change for an 
integer wraparound here. 

d is of type MP4Duration, which is unint64_t. The multiplication is of two 
uint32_t. 

A simple change would be to cast of the operands to MP4Duration which would 
convert both of the operands to MP4Duration before multiplication.

I am using the latest version of mp4v2.

Original issue reported on code.google.com by shankar...@gmail.com on 26 Mar 2014 at 8:33

The text was updated successfully, but these errors were encountered:

GoogleCodeExporter added auto-migrated Priority-Medium Type-Defect labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment