You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
They could coexists with ByteBuf::from and ByteBuf::into_vec if you think these functions are clearer in documentation. I never had problems with looking for From trait implementations.
Now is not possible to use it with generic functions which uses things like T: From<Vec<u8>>. There is reason why there are traits like From trait in rust.
And solution to problems like this #14 require even more extra glue code as before.
The text was updated successfully, but these errors were encountered:
ptrus
added a commit
to oasislabs/oasis-ethwasi-runtime
that referenced
this issue
Sep 23, 2020
Would a PR to re-add From<Vec<u8>> and From<ByteBuf> be accepted? I have run into the exact case mentioned above where I need ByteBuf to implement the From<Vec<u8>> because it is used as a type parameter to another trait with that constraint.
f8c4812
f810459
#3
They could coexists with ByteBuf::from and ByteBuf::into_vec if you think these functions are clearer in documentation. I never had problems with looking for From trait implementations.
Now is not possible to use it with generic functions which uses things like
T: From<Vec<u8>>
. There is reason why there are traits like From trait in rust.And solution to problems like this #14 require even more extra glue code as before.
The text was updated successfully, but these errors were encountered: