Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work.... stringify not called on create #52

Open
brandoncollins7 opened this issue Mar 19, 2018 · 1 comment
Open

Doesn't work.... stringify not called on create #52

brandoncollins7 opened this issue Mar 19, 2018 · 1 comment

Comments

@brandoncollins7
Copy link

brandoncollins7 commented Mar 19, 2018

I have tagged my json column but when I save a new record, the stringify code does not get executed and my object is persisted as [object object]. What is supposed to be calling stringify?

When the same method of this library is called it returns at:

// Only handle arguments withpatchoption. if (!options.patch) { return Model.save.apply(this, arguments); }
https://github.com/seegno/bookshelf-json-columns/blob/master/dist/index.js#L100

and stringify is never called. Seems to call parse ok when I am fetching, but no stringify when I am creating.

@brandoncollins7 brandoncollins7 changed the title Doesn't work.... Doesn't work.... stringify not called on save Mar 19, 2018
@brandoncollins7 brandoncollins7 changed the title Doesn't work.... stringify not called on save Doesn't work.... stringify not called on create Mar 19, 2018
@brandoncollins7
Copy link
Author

I'll admit, I hacked it to support mssql.... are the other db libraries responsible for normally calling stringify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant