Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ExtraFPS] Scale of animated textures is changing #2848

Open
Dan-Linden opened this issue Oct 14, 2024 · 23 comments · Fixed by #3143
Open

[ExtraFPS] Scale of animated textures is changing #2848

Dan-Linden opened this issue Oct 14, 2024 · 23 comments · Fixed by #3143
Assignees
@cosmic-linden
Labels
bug Something isn't working team:viewer
Milestone
2024.09-ExtraFPS

Comments

@Dan-Linden
Copy link
Contributor

Dan-Linden commented Oct 14, 2024 •
edited
Loading

Environment

Second Life Release 7.1.11.11074622243 (64bit)
Release Notes

You are at 140.9, 225.5, 133.7 in Linden Lab HQ 4 located at simhost-0ed1af4f6c09b0a7a.agni
SLURL: http://maps.secondlife.com/secondlife/Linden%20Lab%20HQ%204/141/226/134
(global coordinates 238,989.0, 244,194.0, 133.7)
Second Life Preflight 2024-09-30.11111372425
Release Notes

CPU: Intel(R) Core(TM) i7-5930K CPU @ 3.50GHz (3491.91 MHz)
Memory: 32610 MB
OS Version: Microsoft Windows 10 64-bit (Build 19045.4894)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: NVIDIA GeForce GTX 1080/PCIe/SSE2

Windows Graphics Driver Version: 32.0.15.6590
OpenGL Version: 4.6.0 NVIDIA 565.90

Window size: 1712x1217
Font Size Adjustment: 96pt
UI Scaling: 1
Draw distance: 128m
Bandwidth: 3000kbit/s
LOD factor: 1.75
Render quality: 5
Texture memory: 8192MB
Disk cache: Max size 1638.4 MB (100.0% used)

J2C Decoder Version: KDU v7.10.4
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.23.1 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.14.0.202408091639
CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54
Chromium: 118.0.5993.54
LibVLC Version: 3.0.21
Voice Server Version: Secondlife WebRTC Gateway

Packets Lost: 0/2,157 (0.0%)
October 14 2024 11:56:49

Description

The scale of animated textures changes in the 7.1.11.11074622243 - ExtraFPS viewer
This does not reproduce in the 7.1.10.10800445603 - DeltaFPS viewer.

Reproduction steps

  1. Go to http://maps.secondlife.com/secondlife/Linden%20Lab%20HQ%204/141/226/134
  2. Make the Second Life window relatively small (I used 1512 x 1257)
  3. Watch the animated leaves on the tree.
    Observed: The texture of the leaves occasionally grows larger and smaller.

Expected: The texture of the leaves should appear to move, but not change scale.

Repro 2

  1. Alt-zoom on the animated textures at http://maps.secondlife.com/secondlife/Bug%20Island/49/9/27

Observed: Sometimes the numbers on the textures stop moving or disappear.
Video: https://github.com/user-attachments/assets/cbfbaea0-fee2-4928-b41d-9bb7c03ac890

Expected: The textures never stop moving.
@Dan-Linden Dan-Linden added bug Something isn't working triage Flags issues that need to be triaged labels Oct 14, 2024
@kylelinden kylelinden added this to the 2024.09-ExtraFPS milestone Oct 15, 2024
@kylelinden kylelinden added team:viewer and removed triage Flags issues that need to be triaged labels Oct 15, 2024
@Dan-Linden
Copy link
Contributor Author

From what I can see this is fixed in ExtraFPS 7.1.11.11565212741.

@cosmic-linden
Copy link
Contributor

@Dan-Linden From my limited attempts to test this ticket on develop, I have been unable to reproduce this (I have mostly been working on #2971 ). However, during my investigation, I did notice via a possible bug in the code which could be related. Perhaps we could lower the priority on this ticket, or alternatively we can close this and I could open a ticket later if I get around to fixing that.

(for curious developers reading this, it's the calculation of mExtents in LLFace::getGeometryVolume)

@Dan-Linden
Copy link
Contributor Author

Let's send this to QA and see if it's fixed for them.

@georgebproductengine
Copy link

Passed QA.
Verified on the Second Life Release 7.1.11.11750364439 (64bit) in the scope of https://github.com/secondlife/iqa/issues/381 on Win10/OSX.

@Dan-Linden
Copy link
Contributor Author

Reopened. I'm still seeing this on Second Life Release 7.1.11.11750364439 (64bit)
SLURL: http://maps.secondlife.com/secondlife/Linden%20Lab%20HQ%204/141/226/134
CPU: Intel(R) Core(TM) i7-5930K CPU @ 3.50GHz (3491.92 MHz)
Memory: 32610 MB
OS Version: Microsoft Windows 10 64-bit (Build 19045.5131)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: NVIDIA GeForce GTX 1080/PCIe/SSE2

Correct:
Image

Incorrect:
Image

@cosmic-linden
Copy link
Contributor

I might pick this up later, but don't want to block anyone while I'm working on another ticket (#3104)

@cosmic-linden cosmic-linden removed their assignment Nov 20, 2024
@Dan-Linden
Copy link
Contributor Author

Here's video of the leaves changing at http://maps.secondlife.com/secondlife/Linden%20Lab%20HQ%204/141/226/134 on build 7.1.11.11750364439
https://github.com/user-attachments/assets/c95bec2e-6e12-47c3-ae4d-ef4b652794e0
They look fine on 7.1.10.10800445603 for me.

@akleshchev akleshchev self-assigned this Nov 20, 2024
@Dan-Linden
Copy link
Contributor Author

Something in the octree is changing.
Second Life Release 7.1.11.11750364439 (64bit) / Windows 10/ NVIDIA GeForce GTX 1080/PCIe/SSE2
SLURL: http://maps.secondlife.com/secondlife/Linden%20Lab%20HQ%204/141/226/134

leaves.octree.mp4

@Dan-Linden
Copy link
Contributor Author

This doesn't repro much for me if my viewer is maximized. Maybe this is framerate related. If I shrink the viewer to a quarter of the screen so the FPS is 60+ then this bug reproduces.
I've also been able to reproduce this on a Win11 / GeForce GTX 1660 Ti (laptop)

@Dan-Linden
Copy link
Contributor Author

After shrinking the viewer window size this bug does also reproduce on my Windows/AMD machine and my Mac M1.

OS Version: Microsoft Windows 11 64-bit (Build 22631.4460)
Graphics Card Vendor: ATI Technologies Inc.
Graphics Card: AMD Radeon RX 6800M
Windows Graphics Driver Version: 30.0.15020.1001
OpenGL Version: 4.6.14800 Core Profile Context 21.50.20.01 30.0.15020.1001

@Dan-Linden
Copy link
Contributor Author

This issue does not repro in Develop, but this tree has a different issue in Develop, #3127.

@akleshchev akleshchev removed their assignment Nov 22, 2024
@akleshchev
Copy link
Contributor

Ok, should this be moved to Develop?

@akleshchev
Copy link
Contributor

"scale of aniamted textures" reproes for me if I resize window to be small.

I think fix for scaled textures is a068928
Can not repro after applying it

@cosmic-linden
Copy link
Contributor

cosmic-linden commented Nov 23, 2024 •
edited
Loading

With Dan's reproduction steps, I can reproduce the bug now.

@akleshchev I can still reproduce the bug in release/2024.09-ExtraFPS with a068928 applied

@cosmic-linden
Copy link
Contributor

Looking at Render Metadata > Texture Anim, I see that:

This may be two flavors of the bug with the same root cause, or possibly two distinct bugs.

I will try to repro again in develop, with and without @akleshchev 's cherry pick fix.

@cosmic-linden
Copy link
Contributor

I am unable to reproduce the bug in develop with and without the fix mentioned at a068928 - it would seem that fix is neither necessary nor sufficient.

@akleshchev
Copy link
Contributor

Also can repro, but it didn't repro for some time, looks like it periodically stabilizes. Forcing all textures to be FullRes does not affect it, there is no record in texture console, so it probably isn't fetcher.

@cosmic-linden cosmic-linden linked a pull request Nov 23, 2024 that will close this issue
secondlife/viewer#2768, secondlife/viewer#2848: Partial cherry pick of "Animated pbr textures don't animate" from develop #3143
Merged
@cosmic-linden
Copy link
Contributor

Cherry picking the main fixes from #2768 seemed to fix the issues on my end:

#3143

@dmytrohproductengine
Copy link

Passed QA.

Verified on the Second Life Release 7.1.11.11982653819 (64bit) on Win10/OSX in the scope of IQA#395.

Verified on http://maps.secondlife.com/secondlife/Bug%20Island/49/9/27 location using the "Alt-zoom" option on the animated textures.

Also, the PE Team does not have access to http://maps.secondlife.com/secondlife/Linden%20Lab%20HQ%204/141/226/134 location.
If it is necessary, could you please provide access to that region?
Thanks.

@Dan-Linden
Copy link
Contributor Author

Dan-Linden commented Nov 25, 2024 •
edited
Loading

I still see this on build 7.1.11.11982653819 at http://maps.secondlife.com/secondlife/Linden%20Lab%20HQ%204/142/226/134
Video of leaves: https://github.com/user-attachments/assets/fd825351-30d7-4c1f-85fa-6cb886613ba3

And at http://maps.secondlife.com/secondlife/Bug%20Island/47/15/27
Video of boxes: https://github.com/user-attachments/assets/c76a0dc6-0a8a-40c8-b80f-d799215e184b

@akleshchev
Copy link
Contributor

Fix wasn't merged yet.
#3143

brad-linden added a commit that referenced this issue Nov 26, 2024
@brad-linden
Merge pull request #3143 from secondlife/v-2768_extrafps
7ef6e8f 
#2768, #2848: Partial cherry pick of "Animated pbr textures don't animate" from develop
@vladyslavasproductengine
Copy link

Failed QA.
Verified on the Second Life Release 7.1.11.12041172537 (64bit) on OSX in the scope of secondlife/iqa#401.

Verified on http://maps.secondlife.com/secondlife/Bug%20Island/47/15/27 location using the "Alt-zoom" option on the animated textures.
Win 10: Sometimes the numbers on the textures stop moving
OSX: The numbers on the textures are blurry see the video:
https://github.com/user-attachments/assets/e65ae169-61e3-477b-91d4-f47c940184f0

Also, the PE Team does not have access to http://maps.secondlife.com/secondlife/Linden%20Lab%20HQ%204/141/226/134 location.
If it is necessary, could you please provide access to that region?
Thanks.

@AtlasLinden
Copy link

AtlasLinden commented Nov 27, 2024 •
edited
Loading

The original bug, that is the scale of animated textures, no longer occurs.
Further testing was performed at the given inaccessible region and no longer reproduced on multiple machines.
Passing QA

The textures blurring or animation stopping are not related to the scale and can be investigated elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cosmic-linden cosmic-linden

Labels
bug Something isn't working team:viewer
Projects
None yet
Milestone
2024.09-ExtraFPS
8 participants
@kylelinden @cosmic-linden @AtlasLinden @akleshchev @Dan-Linden @dmytrohproductengine @vladyslavasproductengine @georgebproductengine