Underwater environment is too blue and foggy

[sergiiiproductengine]

Steps to reproduce:

1. Download 7.1.11.11074622243 viewer and login.
2. Teleport to the http://maps.secondlife.com/secondlife/Bug%20Island%202/128/127/12 facing Southeast.
3. Change Render Settings to High-Ultra, Mid, Low-Mid or Low.
4. Observe environment.

Actual result:
Underwater environment is too blue and foggy.

OSX actual screenshots

High - Ultra

Mid

Low - Mid

Low

Win11 actual screenshots

High - Ultra

Mid

Low - Mid

Low

Expected result:
Underwater environment should not be so blue and foggy.
The far away terrain should be slightly blue and foggy.

Expected screenshots

High - Ultra

Mid

Low - Mid

Low

According to the Environment Rendering conformity test plan.
Underwater Rendering - Test 1, 2, 3, 4 - 2) The far away terrain is slightly blue and foggy.

Additional info:
The issue is reproduced on Win10/Win11/OSX.
The issue is not reproduced on the current release viewer (Second Life Release 7.1.10.10800445603).
Note: blue and foggy environment with terrain almost invisible on the current release viewer and differs from expected screenshots provided in the test plan (please, compare actual screenshot below with expected screenshots above).

Actual release 7.1.10.10800445603 screenshots

OSX:

Win10:

OSX Environment

Second Life Release 7.1.11.11074622243 (64bit)
Release Notes

You are at 128.5, 125.6, 11.8 in Bug Island 2 located at simhost-0ad04c4bcce5e167c.agni
SLURL: http://maps.secondlife.com/secondlife/Bug%20Island%202/128/126/12
(global coordinates 260480.0, 249470.0, 11.8)
Second Life Server 2024-09-13.10853867644
Release Notes

CPU: Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (2200 MHz)
Memory: 16384 MB
OS Version: macOS 12.6.0 Darwin 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64
Graphics Card Vendor: ATI Technologies Inc.
Graphics Card: AMD Radeon Pro 555X OpenGL Engine

OpenGL Version: 4.1 ATI-4.8.101

Window size: 1472x920
Font Size Adjustment: 96pt
UI Scaling: 1
Draw distance: 64m
Bandwidth: 3000kbit/s
LOD factor: 1.125
Render quality: 0
Texture memory: 4096MB
Disk cache: Max size 1638.4 MB (0.0% used)
HiDPI display mode:

J2C Decoder Version: KDU v7.10.4
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.23.1 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.14.0.202408091638
CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54
Chromium: 118.0.5993.54
LibVLC Version: 3.0.21
Voice Server Version: Vivox 4.10.0000.32327.5fc3fe7c.5942f08

Packets Lost: 0/640 (0.0%)
October 04 2024 00:04:27

[Dan-Linden]

This may have been fixed by a patch for loading EEP settings. Please test again.

[igorlproductengine]

Failed QA.
Verified on the Second Life Release 7.1.11.11750364439 (64bit) in the scope of https://github.com/secondlife/iqa/issues/381 on Win10/OSX.

There is currently no strong underwater shading as seen previously. Shadows are rendered incorrectly and unattractively. Water transparency is inconsistent; it does not match the expected transparency, and at default settings below High the water appears completely opaque, not as seen in previous versions.

Actual:

[akleshchev]

To me it looks identical.

7.1.10 (deltaFPS)

7.1.11 (extraFPS)

[valeriiaaproductengine]

Failed QA.

In Second Life Release 7.1.11.11982653819 build, the water and environment are not the same as in the test plan. When the graphics settings are set to Mid, the water looks darker than in the screenshots in the test plan. Also, everything becomes very light underwater when the graphics settings are set to High+. The discrepancy with the test plan is also noticeable when the settings are set to Low+. See the screenshots below:

actual_Win10_11982653819_Mid.png:

expected_from_testplan_Mid.png:

actual_Win10_11982653819_High_plus.png:

expected_from_testplan_High_plus.png:

Verified on the Second Life Release 7.1.11.11982653819 (64bit) in the scope of https://github.com/secondlife/iqa/issues/395 on Win10/OSX.

[AtlasLinden]

The behaviour outlined in the above comment is due to a change to the feature table in PBR viewers (7.x+). That is, the Transparent Water setting is now enabled at different graphics quality settings. A much needed update is required for the aforementioned test plan to verify these changes.

As for the initial bug report, environment underwater is too blue and foggy, this is no longer reproducing and appears to match the behaviour seen in DeltaFPS.
Passing QA.

Note that the water normal map is not shown when Transparent Water is disabled: #3151

[canny]

This issue has been linked to a Canny post: Issues when camming under the water's surface. 🎉