Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid.Core in .NET 6 has dependency on Microsoft.Extensions.FileProviders.Abstractions 8.0 #687

Open
ngufra opened this issue Aug 9, 2024 · 6 comments

Comments

@ngufra
Copy link

ngufra commented Aug 9, 2024

This started on Fluid.Core v 2.8

There is a version of FileProviders.Abtractions for .NET 6: https://www.nuget.org/packages/Microsoft.Extensions.FileProviders.Abstractions/6.0.0

This causes runtime issues.
For example when running an azure function .net 6:

[2024-08-09T15:33:08.533Z] Error configuring services in an external startup class. Microsoft.Azure.WebJobs.Extensions.Rpc: Method 'GetChangeToken' in type 'Microsoft.Azure.WebJobs.Extensions.Rpc.ExtensionEndpointDataSource' from assembly 'Microsoft.Azure.WebJobs.Extensions.Rpc, Version=3.0.37.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not have an implementation.
@sebastienros
Copy link
Owner

You can try to add a direct reference to 6.0.0 in your project.
But I'd like to understand how it impacts this specific missing method. These are just abstractions classes and only have a single unrelated package reference.

@ngufra
Copy link
Author

ngufra commented Aug 9, 2024

if I add the nuget for FileProviders.Abtractions 6.0 i get a NU1605 error:

Detected package downgrade: Microsoft.Extensions.FileProviders.Abstractions from 8.0.0 to 6.0.0. Reference the package directly from the project to select a different version.
-> Fluid.Core 2.11.1 -> Microsoft.Extensions.FileProviders.Abstractions (>= 8.0.0)
-> Microsoft.Extensions.FileProviders.Abstractions (>= 6.0.0)

Even if I make it ignore the warning at runtime i get the issue.

For now I cannot go higher that 2.7.
Can the .NET 6 target specify Microsoft.Extensions.FileProviders.Abstractions 6.0?
Thanks.

@hishamco
Copy link
Collaborator

hishamco commented Aug 9, 2024

Why do you need to target Microsoft.Extensions.FileProviders.Abstractions 6.0 while the 8.0 is already referenced by Fluid?

@ngufra
Copy link
Author

ngufra commented Aug 9, 2024

You are correct.
It looks like i would not need to do anything and fuild.core would use Microsoft.Extensions.FileProviders.Abstractions 8.0 that seems to be ok with .net 6.
However with Fluid.Core 2.8 (That references Microsoft.Extensions.FileProviders.Abstractions 8.0) I get some errors at runtime whilst i don't with 2.7
Not sure it's a red herring.

@hishamco
Copy link
Collaborator

hishamco commented Aug 9, 2024

Could you please share a minimal repo? Also make sure to clean nuget cache sometimes weird things could happen, try git clean -xdf

@ngufra
Copy link
Author

ngufra commented Aug 13, 2024

I upgraded my project to .NET 8 and confirm that is binds ok with fluid 2.11.1 in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants