Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Transaction closed" timestamp? #259

Open
sde1000 opened this issue May 18, 2023 · 0 comments
Open

"Transaction closed" timestamp? #259

sde1000 opened this issue May 18, 2023 · 0 comments

Comments

@sde1000
Copy link
Owner

sde1000 commented May 18, 2023

At the moment, transactions have a simple open/closed flag. If we want to know when the transaction was closed we can try to infer it from the date of the most recent transaction line or payment, but we can't be sure. (This may be incorrect in the case of transactions being merged, for example: the merge may result in a closed transaction from multiple open ones, without adding any further translines or payments.)

Some situations have arisen where this would be useful for debugging (eg. "when did this transaction close, and why wasn't it immediately after a payment") and there may be more situations where it's useful when trying to work out what happened.

Would adding a timestamp be sensible? Or would we be better off working on a more general transaction logging system for tracking merges, etc. as discussed in #215?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant