-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coordinator): fix all chunks ready bug #862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgehao
requested review from
0xmountaintop,
icemelon,
colinlyguo and
Thegaram
August 23, 2023 08:38
colinlyguo
previously approved these changes
Aug 23, 2023
…ll into fix/all_chunk_ready_bug
Codecov Report
@@ Coverage Diff @@
## develop #862 +/- ##
===========================================
- Coverage 51.32% 51.17% -0.15%
===========================================
Files 60 60
Lines 5561 5577 +16
===========================================
Hits 2854 2854
- Misses 2468 2484 +16
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0xmountaintop
previously approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just some nitpicks
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
actually, one sql can do it. BUT, this sql is too complex, it's maybe increase the difficulty to maintain.
So still use
chunk_proofs_status
and cron task check it.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated?Breaking change label
Does this PR have the
breaking-change
label?