Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): temp fix gacts/install-geth-tools #770

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

0xmountaintop
Copy link
Member

@0xmountaintop 0xmountaintop commented Aug 10, 2023

Purpose or design rationale of this PR

There might be something wrong with gacts/install-geth-tools@v1's release.

1.12.0 works (see #765)
image

but 1.12.1 not found (see #769)
image

This PR pin the geth tool version as 1.12.0 to avoid such an issue.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop merged commit d10438a into develop Aug 10, 2023
13 checks passed
@0xmountaintop 0xmountaintop deleted the fix/install-geth-tools branch August 10, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants