Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt(libzkp): allow params be shared between multi versions #1499

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

lispc
Copy link
Contributor

@lispc lispc commented Aug 26, 2024

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@lispc lispc requested a review from amoylan2 August 26, 2024 08:22
@georgehao georgehao added the bump-version Bump the version tag for deployment label Aug 26, 2024
@georgehao georgehao marked this pull request as ready for review August 26, 2024 12:58
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.71%. Comparing base (31a6141) to head (ce1d967).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1499   +/-   ##
========================================
  Coverage    51.71%   51.71%           
========================================
  Files          156      156           
  Lines        12763    12763           
========================================
  Hits          6600     6600           
  Misses        5595     5595           
  Partials       568      568           
Flag Coverage Δ
common 42.98% <ø> (ø)
coordinator 17.22% <ø> (ø)
database 42.85% <ø> (ø)
rollup 55.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

roynalnaruto
roynalnaruto previously approved these changes Aug 26, 2024
Copy link
Contributor

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Next steps:

  1. Merge (v0.12.2) Move params out of prover/verifier zkevm-circuits#1404
  2. Tag v0.12.2 and use tag instead of branch in Cargo.toml
  3. Merge (v0.13.1) Move params out of prover/verifier & Additional sanity check zkevm-circuits#1405
  4. Tag v0.13.1 and use tag instead of branch in Cargo.toml

roynalnaruto
roynalnaruto previously approved these changes Aug 26, 2024
Copy link
Contributor

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, updated to use tag instead of branch

Copy link
Contributor

@amoylan2 amoylan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgehao georgehao merged commit 4470c81 into develop Aug 27, 2024
14 checks passed
@georgehao georgehao deleted the opt/libzkp/share-params branch August 27, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants