Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "refactor: use tokio async pattern (#15)" #17

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Revert "refactor: use tokio async pattern (#15)" #17

merged 2 commits into from
Sep 30, 2024

Conversation

0xmountaintop
Copy link
Member

@0xmountaintop 0xmountaintop commented Sep 29, 2024 •
edited
Loading

revert because

Cannot start a runtime from within a runtime. This happens because a function (like `block_on`) attempted to block the current thread while the thread is being used to drive asynchronous tasks.

@0xmountaintop 0xmountaintop changed the title Haoyu/revert tokio Revert "refactor: use tokio async pattern (#15)" Sep 29, 2024
@0xmountaintop 0xmountaintop marked this pull request as ready for review September 30, 2024 00:02
@0xmountaintop 0xmountaintop merged commit 0b2105c into main Sep 30, 2024
1 check passed
@0xmountaintop 0xmountaintop deleted the haoyu/revert_tokio branch September 30, 2024 00:03
0xmountaintop added a commit that referenced this pull request Oct 4, 2024
@0xmountaintop
Revert "Revert "refactor: use tokio async pattern (#15)" (#17)"
2907e41 
This reverts commit 0b2105c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmountaintop @lispc