Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[don't-merge] fix: use sync-halo2-lib-0.4.0 branch of halo2_proofs #22

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

silathdiir
Copy link

@silathdiir silathdiir commented Oct 26, 2023

Summary

  • use halo2_proof sync-halo2-lib-0.4.0 branch.
  • copy only necessary code from halo2-base/src/utils/mod.rs of [WIP] Sync halo2 lib 0.4.0 #21 to utils.rs to make build work.
  • add inline functions zero() (returns F::ZERO) and one() (returns F::ONE) to ScalarField to avoid fixes in other files.

Test

  • bn254::tests::pairing::test_pairing failed with NOT ENOUGH ADVICE COLUMNS IN PHASE 0.
  • bench tests failed with No such file or directory.
failures:
    bn254::tests::ec_add::bench_ec_add
    bn254::tests::fixed_base_msm::bench_fixed_base_msm
    bn254::tests::msm::bench_msm
    bn254::tests::pairing::bench_pairing
    bn254::tests::pairing::test_pairing
    secp256k1::tests::ecdsa::bench_secp256k1_ecdsa

@zhenfeizhang
Copy link

LGTM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants