Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EANY should disappear as a kind, and be replaced with ECALL and EBREAK. #545

Open
matthiasgoergens opened this issue Nov 4, 2024 · 0 comments
Assignees

Comments

@matthiasgoergens
Copy link
Collaborator

matthiasgoergens commented Nov 4, 2024

Risc0 uses an idiosyncratic decoding process. That forces them to introduce a new instruction kind, EANY that doesn't appear anywhere in the Risc-V spec. We inherited that limitation when we copy-and-pasted their code.

I suggest we remove EANY and replace it with ECALL and EBREAK, instructions that are actually mentioned in the spec.

EANY should disappear as a kind, and be replaced with ECALL and EBREAK.

EANY ain't even an instruction that appears in Risc-V. It's just an artifact of Risc0's design decisions.

(But we can do that in a subsequent PR.)

Originally posted by @matthiasgoergens in #538 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants