Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for "." as a thousand separator #59

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

emarondan
Copy link
Contributor

@emarondan emarondan commented Sep 14, 2023

price_parser/parser.py Outdated Show resolved Hide resolved
price_parser/parser.py Outdated Show resolved Hide resolved
price_parser/parser.py Outdated Show resolved Hide resolved
price_parser/parser.py Outdated Show resolved Hide resolved
price_parser/parser.py Outdated Show resolved Hide resolved
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I think we can ignore the 2 failing jobs (3.6 should be dropped, probably along with 3.7, and the mypy issue seems like something a new mypy should not complain about given the if ensures digit_group_separator is not None).

@wRAR
Copy link
Member

wRAR commented Sep 28, 2023

3.6 should be dropped, probably along with 3.7

I've created #60 for this after seeing the failures here.

@Gallaecio Gallaecio merged commit bfd1f14 into scrapinghub:master Oct 17, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"." incorrectly interpreted as a thousands separator
3 participants