Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show launch page when all favorites are removed #36

Open
scottrohrig opened this issue Jan 15, 2022 · 0 comments
Open

Show launch page when all favorites are removed #36

scottrohrig opened this issue Jan 15, 2022 · 0 comments
Assignees
@scottrohrig
Labels
bug Something isn't working

Comments

@scottrohrig
Copy link
Owner

Description

  • When a user has removed all favorites and the clicks the favorites button, the console will show the following error:
Uncaught TypeError: Cannot read properties of undefined (reading 'name')
    at makeFirstResult (script.js:256:24)

Requirements

  • Add validation check for empty favorites
  • Simple solution, refresh the page so the default empty results card shows
  • Longer/cleaner solution, make a function to dynamically generate that default view card from script.js
@scottrohrig scottrohrig added the bug Something isn't working label Jan 15, 2022
@scottrohrig scottrohrig self-assigned this Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottrohrig scottrohrig

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scottrohrig