Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Cancelable #7

Open
imagejan opened this issue Oct 31, 2017 · 1 comment
Open

Implement Cancelable #7

imagejan opened this issue Oct 31, 2017 · 1 comment
Labels
enhancement

Comments

@imagejan
Copy link
Member

Any batch processor command should implement org.scijava.Cancelable so that batch processing can be interrupted.
@imagejan
Copy link
Member Author

ModuleBatchProcessor is a DynamicCommand, so it implements Cancelable.

However, there's currently no way to call its cancel() method during batch processing (and nothing checks isCanceled() during execution). Should we make ModuleBatchProcessor implement Task to achieve this (also to display a progress bar...) ?

The intended use case would be to (possibly) reuse the Kill button in the script editor to stop batch executions started with the Batch button; or to listen for the Esc key being pressed (by subscribing to the respective event using EventService?) whenever we run batch processing.

@ctrueden do you have advice regarding the "SciJava" way of doing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@imagejan