Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in PDF link in publication fill #536

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Luen
Copy link

@Luen Luen commented Apr 11, 2024

Hi team,

I noticed that Scholarly doesn't output the PDF link (only pub_url), so I'm attempting to add this feature.

Description

Edited PublicationParser() fill() in publication_parser.py to add HTML parsing for the pdf link.

Example publication with pdf link: https://scholar.google.com/citations?view_op=view_citation&hl=en&user=ynWS968AAAAJ&citation_for_view=ynWS968AAAAJ:8xutWZnSdmoC
Screenshot of Google Scholar publication with PDF link

Checklist

  • Check that the base branch is set to develop and not main.
  • Ensure that the documentation will be consistent with the code upon merging.
  • Add a line or a few lines that check the new features added.
  • Ensure that unit tests pass.
    If you don't have a premium proxy, some of the tests will be skipped.
    The tests that are run should pass without raising
    MaxTriesExceededException or other exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant