Add in PDF link in publication fill #536
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
I noticed that Scholarly doesn't output the PDF link (only pub_url), so I'm attempting to add this feature.
Description
Edited PublicationParser() fill() in publication_parser.py to add HTML parsing for the pdf link.
Example publication with pdf link: https://scholar.google.com/citations?view_op=view_citation&hl=en&user=ynWS968AAAAJ&citation_for_view=ynWS968AAAAJ:8xutWZnSdmoC
Checklist
develop
and notmain
.If you don't have a premium proxy, some of the tests will be skipped.
The tests that are run should pass without raising
MaxTriesExceededException
or other exceptions.