Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMS serializer implements Symfony serializer #1484

Closed
themark147 opened this issue Apr 26, 2023 · 4 comments
Closed

JMS serializer implements Symfony serializer #1484

themark147 opened this issue Apr 26, 2023 · 4 comments

Comments

@themark147
Copy link

Hello,

In SF 6.3 we will have feature https://symfony.com/blog/new-in-symfony-6-3-mapping-request-data-to-typed-objects

but RequestPayloadValueResolver resolver requires Only interfaces from symfony serializer ... its any change JMS serializer will be implements symfony serializer interface? cause JMS is used by JMS bundle and FOS rest bundle

thanks

@scyzoryck
Copy link
Collaborator

Hi!
Thanks for sharing!
It looks like an interesting feature, however adding dependency on interface from symfony to this package directly might be not the best idea. Strong coupling will introduce more breaking changes, not needed for most of the projects.
I think we might think about some kind of adapter that will make it work with symfony inside JMS bundle package. But I am open for other ideas too.

Best, scyzoryck.

@themark147
Copy link
Author

yea u right I should start discuss about that feature in JMS Bundle sorry. Also agree with coupling. I will try to think about it how it can be done with some adapter right in bundle

Thanks!

@scyzoryck
Copy link
Collaborator

No problem! Feel free to submit pull request. I will be glad to help with code review or the merge process.

Best scyzoryck.

@scyzoryck
Copy link
Collaborator

Let's move discussion to: schmittjoh/JMSSerializerBundle#928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants