sealed oneof option/annotation instead of special name

[dsilvasc]

Sealed oneofs are only generated when the oneof name is sealed_value. For people with existing schemas (or schemas shared across multi-language teams where others might prefer another name), would it be possible to allow annotating the message or the oneof?

Maybe something like option (scalapb.message).sealed_oneof = true?

[thesamet]

Yes, that should be fairly straightforward. Would you have time to put together a PR? There are initial instructions on getting started here: https://github.com/scalapb/ScalaPB/blob/master/CONTRIBUTING.md and this is an example commit that adds an option: 82bbd69

[dsilvasc]

Thanks for the pointers -- I'll give it a shot.

[thesamet]

@dsilvasc : 1. is it something that you still need? 2. Will you be able to give it a shot?

[thesamet]

Closing due to inactivity. Please feel free to comment if there's still interest in it and we can re-open.

[wesselvdv]

Was there ever any attempt for this?

[acruise]

In cases where I control the proto and am willing to live with backwards compatibility risks, it'd be great to be able to apply sealed oneof globally, or per message, without the sealedFoo and SealedFoo naming convention leaking into the generated Scala. :/