Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit distribution modal works & also updates ballot button #80

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Edit distribution modal works & also updates ballot button #80

merged 2 commits into from
Sep 26, 2023

Conversation

Chirag018
Copy link
Contributor

@Chirag018 Chirag018 commented Sep 25, 2023 •
edited
Loading

Closes #62 #52

Edit distribution modal updates on modifying the changes and also doesn't cross the limit.

Screenshot 2023-09-26 at 12 46 23 AM Screenshot 2023-09-26 at 12 46 37 AM Screenshot 2023-09-26 at 12 46 44 AM Screenshot 2023-09-26 at 12 46 52 AM Screenshot 2023-09-26 at 12 47 01 AM Screenshot 2023-09-26 at 12 47 08 AM

@Chirag018 Chirag018 changed the title Edit distribution modal works Edit distribution modal works & also updates ballot button Sep 25, 2023
escottalexander
escottalexander reviewed Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@escottalexander escottalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great. Just one small change. Add back the .env.example file so others can reference it.

@Chirag018
Copy link
Contributor Author

This works great. Just one small change. Add back the .env.example file so others can reference it.

Hey, I think so was deleted mistakenly, mybad didn't review it,

fixed it now!!

escottalexander
escottalexander approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@escottalexander escottalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@escottalexander escottalexander merged commit d0a39e6 into scaffold-eth:main Sep 26, 2023
1 check passed
@Chirag018 Chirag018 mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escottalexander escottalexander escottalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using the Edit Distribution modal, the distributions doesn't actually update and any number is allowed.
2 participants
@Chirag018 @escottalexander