Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a countdown component #75

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Added a countdown component #75

merged 4 commits into from
Sep 21, 2023

Conversation

luloxi
Copy link
Contributor

@luloxi luloxi commented Sep 21, 2023

Description

Added a CountdownTimer component that takes a timestamp and displays it as a live countdown or a finished date and time

Related Issues

Closes #46

@ZakGriffith
Copy link
Member

I like it! Until we fully know from OP how we will get this info this should do nicely. One small tweak, it's weird to see the hardcoded date for a second after switching between Projects and Lists as seen here. Maybe we either start it as blank or if possible have the countdown timer displayed instantly.

CountdownTimer

@luloxi
Copy link
Contributor Author

luloxi commented Sep 21, 2023

It should work properly now!

(btw how did you record that gif?)

@escottalexander
Copy link
Collaborator

Confirmed it displays instantly now. Nice work!

@escottalexander escottalexander merged commit cd80b75 into scaffold-eth:main Sep 21, 2023
1 check passed
@luloxi luloxi deleted the countdown-timer branch September 22, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Countdown timer
3 participants