Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BPCells compatibility (JackStraw + RunPCA) #8271

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bnprks
Copy link

@bnprks bnprks commented Jan 6, 2024

These are some changes brought about from this BPCells issue, then referenced in Seurat issue #8267

  1. Make the JackStraw function compatible with BPCells objects. This approach shuffles the matrix subset as a dense matrix, but leaves the remainder of the data on-disk. For best performance the BPCells object should be stored in row-major order so that the matrix subsets can be performed efficiently, but it will work either way.
  2. Improve performance of RunPCA by using the BPCells svds function. This takes advantage of the same solver RSpectra uses, but at the C++ level to avoid overheads of repeatedly creating BPCells C++ objects on each solver iteration. It also avoids the pitfall that irlba can only use its fast C version with in-memory matrices and otherwise falls back to a slower pure-R implemenation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant