Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoryTLESource._get_tle always returns something #24

Open
enritoomey opened this issue Dec 28, 2018 · 1 comment
Open

MemoryTLESource._get_tle always returns something #24

enritoomey opened this issue Dec 28, 2018 · 1 comment
Labels

Comments

@enritoomey
Copy link

MemoryTLESource._get_tle(...) always return some TLE as long as the cache is not empty. This is not a bug by itself, but when WSTLESource._get_tle(...) method calls it, it will always return the TLE in the cache no matter how old it is. I don't think this is the expected behaviour, nor that is useful in any case. There should be an extra parameter to make WSTLESource._get_tle(...) for another TLE if the closes cache tle is farther away from the requested epoch than desired. If WSTLESource._fetch_tle(...) does not return a newer TLE, the return that of the cache, with a warning message.

@astrojuanlu
Copy link
Contributor

...I have been just hit by this. I totally agree, this is not useful. I declare it a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants