Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading and writing VAPID keys in typical base64url format #13

Open
tysonzero opened this issue Oct 4, 2024 · 1 comment
Open

Comments

@tysonzero
Copy link

Various tools give and receive VAPID keys in the typical base64 URL format, and converting between that format and the format used by this library is sufficiently error-prone and non-trivial to justify direct support IMO.

@tysonzero
Copy link
Author

Ok perhaps error-prone and non-trivial is a slight exaggeration, but to give additional context I was running into a JWT error and it wasn't clear if the issue was in the hand-written key format conversion code or in this library, slowing down debugging substantially. It now appears that the conversion code was fine and that the issue was with this library (or a dep) and has seen been fixed in 0.4.

Being able to just plug in the same base64 URL format I was using with node's web-push library would make debugging easier and just avoid some noisy base64 handling code from existing within the application, particularly given that this library already depends on base64-bytestring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant