Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numBlob to the parameters for the ex_init_params method. #543

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mvlopri
Copy link
Collaborator

@mvlopri mvlopri commented Nov 13, 2024

This was needed to initialize a new exodus file from inside of exodus.py using the init_params argument of the exodus class.

Add a test to ensure this capability does not regress and that ex_init_params works if new arguments need to be initalized in the future.

Address the tests not running due to the test and exodus.py script being placed in lib64. This still needs work to ensure it finds the libexodus.so library because SEACAS_LIBDIR is left blank during the CMake configure step.

This was needed to initialize a new exodus file from inside of
exodus.py using the init_params argument of the exodus class.

Add a test to ensure this capability does not regress and that
ex_init_params works if new arguments need to be initalized in the
future.

Address the tests not running due to the test and exodus.py script
being placed in lib64. This still needs work to ensure it finds the
libexodus.so library because SEACAS_LIBDIR is left blank during the
CMake configure step.
Copy link
Member

@gsjaardema gsjaardema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsjaardema gsjaardema merged commit 7ae62fe into sandialabs:master Nov 14, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants