Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seacas patch to support Pamgen as a TriBITS external compliant pa… #508

Merged

Conversation

tonnguy
Copy link
Contributor

@tonnguy tonnguy commented Oct 2, 2024

…ckage.

These changes would support Pamgen being used as a TriBITS external compliant package. This would enable installing Pamgem with Trilinos and using Pangem within seacas for example.

This would resolve errors related to duplicate Pangem::all_libs targets being declared from trying to build trilinos and seacas with Pamgen.

Copy link
Contributor

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why put this in a patch file? Why not just directly modify the files on 'master':

That will work for both of the use cases:

  1. SEACAS and Pamgen are built as TriBITS packages from within the Trilinos TriBITS CMake project
  2. Pamgen is built and installed as part of the Trilinos TriBITS CMake project and then SEACAS is built in its own CMake project that pulls in Pamgen as a TriBITS-compliant external package (which is what this issue is about?)

@tonnguy
Copy link
Contributor Author

tonnguy commented Oct 2, 2024

I didn't realize that could work for both use cases, I can update this branch to apply the patch directly.

…oth use cases of building SEACAS and Pamgen as TriBITS packages and building Pamgen as a TriBITS external compliant package within seacas.
@gsjaardema
Copy link
Member

Why put this in a patch file? Why not just directly modify the files on 'master':

Good catch. I only looked at the changes and didn't realize it was a patch file....

Copy link
Contributor

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! (Delete 60 lines and change one line and not lose any functionality. What is not to love about that :-))

@tonnguy
Copy link
Contributor Author

tonnguy commented Oct 2, 2024

@gsjaardema I didn't have write access to this repository and can't merge. Would I need to be granted write access? Or if this can be merge without granting permissions that would work too.

@gsjaardema gsjaardema merged commit 2d4c7ce into sandialabs:master Oct 2, 2024
48 checks passed
@gsjaardema
Copy link
Member

Thanks for working on this.

@tonnguy
Copy link
Contributor Author

tonnguy commented Oct 2, 2024

Thanks for working on this.

Thank you, Greg and Ross! I'm very new to using TriBITS and SEACAS so this was a good learning experience also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants