Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rho -> albedo #62

Open
nschorgh opened this issue Apr 6, 2022 · 4 comments · Fixed by #64
Open

rho -> albedo #62

nschorgh opened this issue Apr 6, 2022 · 4 comments · Fixed by #64
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@nschorgh
Copy link
Collaborator

nschorgh commented Apr 6, 2022

https://github.com/sampotter/python-flux/blob/8cb4e46368b1278975746899401872b72a29bf17/src/flux/model.py#L8

At some point we decided to rename rho to albedo here, because in the paper rho is left of the sum.
@nschorgh
Copy link
Collaborator Author

Also, it would be good to return B from compute_steady_state_temp, so the user can plot maps of only the visible portion of the irradiance.

@nschorgh
Copy link
Collaborator Author

And the E.ndim == 2 option for an extended solar disk could also be re-inserted into compute_steady_state_temp.

@steo85it
Copy link
Collaborator

steo85it commented Apr 21, 2022 •
edited
Loading

And the E.ndim == 2 option for an extended solar disk could also be re-inserted into compute_steady_state_temp.

About this last point, is the "spinup" branch version addressing this? (also for model.py )

@steo85it steo85it linked a pull request Apr 25, 2022 that will close this issue
extended light source (Sun) with multi-threading + other minor updates to thermal model for spinup #64
Merged
@steo85it steo85it removed a link to a pull request Apr 25, 2022
extended light source (Sun) with multi-threading + other minor updates to thermal model for spinup #64
Merged
@steo85it steo85it linked a pull request Apr 25, 2022 that will close this issue
extended light source (Sun) with multi-threading + other minor updates to thermal model for spinup #64
Merged
@steo85it
Copy link
Collaborator

(the rho->albedo renaming issue is still open)

@steo85it steo85it added invalid This doesn't seem right enhancement New feature or request labels Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
2 participants
@nschorgh @steo85it