Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macro): remove unused 'concat_args' macro #10

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

noelmcloughlin
Copy link
Member

This PR removes a macro declared but never invoked.

@myii myii requested a review from alxwr July 3, 2019 18:39
@myii
Copy link
Member

myii commented Jul 3, 2019

@noelmcloughlin Let's get feedback from @alxwr -- maybe there was something in the pipeline to make use of this macro soon...

@noelmcloughlin
Copy link
Member Author

Hi @alxwr could you give feedback

Copy link
Member

@aboe76 aboe76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see 'concat_args' used anywhere so I don't see an issue here.

@noelmcloughlin
Copy link
Member Author

Thanks @aboe76
The macro looks useful so I added here: saltstack-formulas/template-formula#134 (comment)

@noelmcloughlin noelmcloughlin merged commit 8900125 into saltstack-formulas:master Jul 24, 2019
@noelmcloughlin noelmcloughlin deleted the macro branch July 24, 2019 18:46
@saltstack-formulas-travis

🎉 This PR is included in version 3.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants