Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop spinners on caught error #407

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix: stop spinners on caught error #407

merged 2 commits into from
Oct 2, 2023

Conversation

mshanemc
Copy link
Contributor

  • stop any spinners to prevent it from unintentionally swallowing output.
  • If there is an active spinner, it'll say "Error" (in our standard red color) instead of "Done" for clarity

@W-14095032@
forcedotcom/cli#2434

@mshanemc mshanemc mentioned this pull request Sep 28, 2023
Merged
shetzel
shetzel approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@shetzel shetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test we can create to catch a regression?

@shetzel
Copy link
Contributor

shetzel commented Oct 2, 2023

QA looks good
Screenshot 2023-10-02 at 2 43 30 PM

@shetzel shetzel merged commit 13c1124 into main Oct 2, 2023
37 checks passed
@shetzel shetzel deleted the sm/stop-spinners-on-catch branch October 2, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shetzel shetzel shetzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshanemc @shetzel