Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup service #9

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Setup service #9

merged 2 commits into from
Aug 16, 2024

Conversation

falvaradorodriguez
Copy link
Contributor

@falvaradorodriguez falvaradorodriguez commented Aug 6, 2024

Closes #1

@falvaradorodriguez falvaradorodriguez marked this pull request as ready for review August 6, 2024 11:29
@falvaradorodriguez falvaradorodriguez requested a review from a team August 6, 2024 11:29
@falvaradorodriguez falvaradorodriguez self-assigned this Aug 6, 2024
setup.cfg Outdated
known_first_party = safe_transaction_service
known_gnosis = py_eth_sig_utils,gnosis
known_fastapi = fastapi,pydantic
sections = FUTURE,STDLIB,FASTAPI,THIRDPARTY,GNOSIS,FIRSTPARTY,LOCALFOLDER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe instead GNOSIS

setup.cfg Outdated
[isort]
profile = black
default_section = THIRDPARTY
known_first_party = safe_transaction_service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe safe_queue_service?

setup.cfg Outdated
profile = black
default_section = THIRDPARTY
known_first_party = safe_transaction_service
known_gnosis = py_eth_sig_utils,gnosis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review if there are more gnosis keywords

.gitignore Outdated

# Django
staticfiles/
safe_transaction_service/media
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safe_queue_Service? Have we meda folder?

.gitignore Outdated
# Provided default Pycharm Run/Debug Configurations should be tracked by git
# In case of local modifications made by Pycharm, use update-index command
# for each changed file, like this:
# git update-index --assume-unchanged .idea/safe_transaction_service.iml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this comment can be removed.

@falvaradorodriguez falvaradorodriguez merged commit 3975571 into main Aug 16, 2024
4 checks passed
@falvaradorodriguez falvaradorodriguez deleted the setup-service branch August 16, 2024 08:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup service
2 participants