Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix lint action + skip release gracefully #170

Merged
merged 1 commit into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ jobs:

- run: yarn install

- uses: Maggi64/eslint-plus-action@master
- name: Run lint
run: npm run lint:report
continue-on-error: true

- name: Annotate code with linting results
uses: ataylorme/eslint-annotate-action@v3
with:
npmInstall: false
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
report-json: "eslint_report.json"
5 changes: 2 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,16 @@ jobs:
git log "$OLD_VERSION"..HEAD --pretty=format:"* %s" > CHANGELOG.md
else
echo "Version $OLD_VERSION hasn't changed, skipping the release"
exit 1
fi

- name: Create a git tag
if: success()
if: steps.version.outputs.version
run: git tag $NEW_VERSION && git push --tags
env:
NEW_VERSION: ${{ steps.version.outputs.version }}

- name: GitHub release
if: success()
if: steps.version.outputs.version
uses: actions/create-release@v1
id: create_release
with:
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"scripts": {
"lint": "tsc && eslint \"./src/**/*\"",
"lint:fix": "yarn lint --fix",
"lint:report": "yarn lint --output-file eslint_report.json --format json",
"build": "rm -rf dist && tsc",
"prepublishOnly": "yarn lint && yarn test:check && yarn build",
"prettier": "prettier -w './**/*.ts'",
Expand Down
Loading