Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sender and Recipient hooks #45

Open
smol-ninja opened this issue Apr 15, 2024 · 5 comments
Open

Add Sender and Recipient hooks #45

smol-ninja opened this issue Apr 15, 2024 · 5 comments
Labels
effort: medium Default level of effort. priority: 3 Nice-to-have. Willing to ship without this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@smol-ninja
Copy link
Member

smol-ninja commented Apr 15, 2024 •
edited
Loading

As discussed in #33, add the following hooks to the Flow protocol:

  • onStreamWithdrawn on both Sender and Recipient
  • onStreamPause on Recipient
  • onStreamRefund on Recipient
  • onAdjustRarePerSecond on Recipient
@smol-ninja smol-ninja added effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Apr 15, 2024
@andreivladbrg
Copy link
Member

andreivladbrg commented Apr 15, 2024 •
edited
Loading

i would suggest (to be more efficient) to implement the hooks at the end of the timeline (after we implement all the other features)

i am saying this because we know from lockup, refactoring/modifying the tests of the hook functions is super time consuming

do you agree?

@smol-ninja
Copy link
Member Author

I agree its not priority 1.

@andreivladbrg

This comment was marked as resolved.

Sign in to view
@smol-ninja

This comment was marked as resolved.

Sign in to view
@andreivladbrg
Copy link
Member

andreivladbrg commented Jul 2, 2024 •
edited
Loading

As discussed privately with @smol-ninja

The hooks here are much more complicated than those in the lockup contract due to the debt. Also, since we’ve changed their design in lockup, we propose to put this on hold for the first release of Flow and see if there is a request for it.

Temporarily locking this issue

@sablier-labs sablier-labs locked as resolved and limited conversation to collaborators Jul 2, 2024
@smol-ninja smol-ninja added priority: 3 Nice-to-have. Willing to ship without this. and removed priority: 2 We will do our best to deal with this. labels Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort: medium Default level of effort. priority: 3 Nice-to-have. Willing to ship without this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smol-ninja @andreivladbrg