You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I still have to look at the code more thourougly, but I'd like to make a suggestion after just a few minutes.
It would improve your product if you separated the outline of the component and the lines wrapper.
Right now you're using the same css variable to control the color for both, those things. But, the grid and the outline serve different purposes. The inner grid's color needs to flexible enough to change on demand to meet the user's need for contrast based on the subject image. The component outline, on the other hand, very much touches the host interface. Where the two meet can make or break the look and feel of the host application.
I understand it's possible to override these, but in my opinion, this component has tremendous potential. It's probably best to make it as easy as possible for the most developers to get up to speed quickly with the least amount of friction... effortless adoption. Over time the depth, quality, and ability to customize you're working towards (bravo) will become increasingly valuable. During the first few minutes, they should be invisible.
Anyway... GREAT WORK.
It has the most potential of every one I've seen so far.
I hope this helps.
Thank you
Brandon
The text was updated successfully, but these errors were encountered:
First Exceptional work.
I still have to look at the code more thourougly, but I'd like to make a suggestion after just a few minutes.
It would improve your product if you separated the outline of the component and the lines wrapper.
Right now you're using the same css variable to control the color for both, those things. But, the grid and the outline serve different purposes. The inner grid's color needs to flexible enough to change on demand to meet the user's need for contrast based on the subject image. The component outline, on the other hand, very much touches the host interface. Where the two meet can make or break the look and feel of the host application.
I understand it's possible to override these, but in my opinion, this component has tremendous potential. It's probably best to make it as easy as possible for the most developers to get up to speed quickly with the least amount of friction... effortless adoption. Over time the depth, quality, and ability to customize you're working towards (bravo) will become increasingly valuable. During the first few minutes, they should be invisible.
Anyway... GREAT WORK.
It has the most potential of every one I've seen so far.
I hope this helps.
Thank you
Brandon
The text was updated successfully, but these errors were encountered: