Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate grid lines from control outline. #4

Open
brandonsaxeme opened this issue Sep 14, 2023 · 1 comment
Open

Separate grid lines from control outline. #4

brandonsaxeme opened this issue Sep 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@brandonsaxeme
Copy link

First Exceptional work.

I still have to look at the code more thourougly, but I'd like to make a suggestion after just a few minutes.

It would improve your product if you separated the outline of the component and the lines wrapper.

Right now you're using the same css variable to control the color for both, those things. But, the grid and the outline serve different purposes. The inner grid's color needs to flexible enough to change on demand to meet the user's need for contrast based on the subject image. The component outline, on the other hand, very much touches the host interface. Where the two meet can make or break the look and feel of the host application.

I understand it's possible to override these, but in my opinion, this component has tremendous potential. It's probably best to make it as easy as possible for the most developers to get up to speed quickly with the least amount of friction... effortless adoption. Over time the depth, quality, and ability to customize you're working towards (bravo) will become increasingly valuable. During the first few minutes, they should be invisible.

Anyway... GREAT WORK.

It has the most potential of every one I've seen so far.

I hope this helps.

Thank you

Brandon

@sabine
Copy link
Owner

sabine commented Oct 4, 2023

Thanks for the feedback, this is an entirely reasonable request. I'll include that in the next version when I get back to this. 🙂

@sabine sabine added the enhancement New feature or request label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants