fix: Optionally chain the setCaretPosition element focus
#819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-yadav
reviewed
Feb 25, 2024
| @@ -235,7 +235,7 @@ export function setCaretPosition(el: HTMLInputElement, caretPos: number) { | |||
| } | |||
|
|
|||
| // fail city, fortunately this never happens (as far as I've tested) :) | |||
| el.focus(); | |||
| el.focus?.(); | |||
There was a problem hiding this comment.
Q: What is the element type coming here. This function expects the element type to be input. Can you share more details on how the custom input is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue/change
We are using a custom input component which utilizes increment/decrement buttons to add/subtract a set step to the value. When either button is clicked on the element which is passed to the
setCaretPositionfunction does not have a focus function so it errors out (see screenshot below) and therefore never calls theonValueChangefunction with the updated value.Describe the changes proposed/implemented in this PR
Add optional chaining to the focus function call inside the
setCaretPositionfunction.Screenshot (If applicable)
Please check which browsers were used for testing