You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although those separators should not be identical I don't think react-number-format should throw an error.
IMO it should show an warning informing the developers and it should still render some output; Informing developers allows them to see and fix the issue upstream. Renderign a value would enable consumers of the plugin to not provide a broken experience.
Throwing an error is impacting flows on real websites. Imagine a checkout flow interrupted by a formatting plugin.
Describe the issue and the actual behavior
When
thousandSeparator
anddecimalSeparator
are similar, the plugin throws an Error.Describe the expected behavior
Although those separators should not be identical I don't think
react-number-format
should throw an error.IMO it should show an warning informing the developers and it should still render some output; Informing developers allows them to see and fix the issue upstream. Renderign a value would enable consumers of the plugin to not provide a broken experience.
Throwing an error is impacting flows on real websites. Imagine a checkout flow interrupted by a formatting plugin.
Provide a CodeSandbox link illustrating the issue
Not needed
Nice to have
Communicate this limitation in the docs
The text was updated successfully, but these errors were encountered: