Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export conflicts with fetch Response #76

Open
ryanve opened this issue Dec 31, 2017 · 3 comments
Open

Export conflicts with fetch Response #76

ryanve opened this issue Dec 31, 2017 · 3 comments

Comments

@ryanve
Copy link
Owner

ryanve commented Dec 31, 2017

Response is the name used in our root export but the native fetch API adds window.Response as part of that standard. What is the best way to mitigate conflict with this? Rename the export? Ideas? How should we communicate this change?

@amanssit
Copy link

Hi @ryanve I am also getting this issue. Response.js Response object getting conflicts with fetch Response.

@ryanve
Copy link
Owner Author

ryanve commented Aug 8, 2019

Ok I'll have to do a new version with a new export name. I'll post here when I do!

@ryanve
Copy link
Owner Author

ryanve commented Aug 8, 2019

noConflict restores the fetch Response and returns a reference to the library

let R = Response.noConflict() 

See noConflict in the source to see how it works : )

@amanssit how does that work for you for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants