Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synced all research tab buttons, fixes #290 #497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Synced all research tab buttons, fixes #290 #497

wants to merge 1 commit into from

Commits on Aug 21, 2024

  1. Synced all research tab buttons, fixes rwmt#290 

    This should sync stop research, dev finish now, and dev apply techprints. This required a sync worker delegate for `ResearchManager` to work.

I've left the current syncing for selecting research by using `MainTabWindow_Research.DoBeginResearch`, and made `ResearchManager.SetCurrentProject` debug-only. I've done this due to `ResearchManager.SetCurrentProject` being called by "Dev: Finish now" button, which would allow anyone without ability to execute debug-only methods to change their active research to any possible research, ignoring any prerequisites.

Alternative approach to this would be to drop the current sync method and make `ResearchManager.SetCurrentProject` synced normally, and then applying a Harmony patch to it which would check if the selected research is valid (and prevent it from being executed if not allowed).
    @SokyranTheDragon
    SokyranTheDragon committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2254d2e View commit details
    Browse the repository at this point in the history