Sync majority of new gizmos added in 1.5/Anomaly #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the psychic ritual gizmos were synced yet. Some of those sync lambda methods/delegates likely could have been synced through a different, non-lambda method. As I was going through the list of gizmos in the game I didn't really consider it for some of them at the time. For obvious reasons, the Anomaly exclusive gizmos could not be tested until the DLC releases. All non-dev mode non-Anomaly gizmos were tested. A big portion of dev mode gizmos was tested as well. Additional info: - The 3 new sync workers are needed for some of the dev mode gizmos - `TradeRequestComp` sync worker is not needed, as it's a subtype of `WorldObjectComp` and we have an implicit sync worker for it - A dev mode gizmo for `CompToxifier` needed to be synced as it would cause infinite loop otherwise (it would keep syncing commands infinitely) - `Hediff_DeathRefusal` transforms a field of type `Command_ActionWithLimitedUseCount`. - It calls a method that requires one of its delegates to not be null/return a value - I believe there is no point to sync the delegate itself, as it likely wouldn't have any effect - `Building_BlastingCharge:Command_Detonate` syncing was removed, and instead synced through `CompExplosive.StartWick` - It should be more compatible with mods, and won't make any difference besides that - `Blueprint_Build.ChangeStyleOfAllSelected` won't be synced if nothing is selected, just as a precaution - Added a method to register a local func sync method - Sync delegates already had a method for that, and it was now needed by sync methods
SokyranTheDragon
added
1.5
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the psychic ritual gizmos were synced yet.
Some of those sync lambda methods/delegates likely could have been synced through a different, non-lambda method. As I was going through the list of gizmos in the game I didn't really consider it for some of them at the time.
For obvious reasons, the Anomaly exclusive gizmos could not be tested until the DLC releases.
All non-dev mode non-Anomaly gizmos were tested. A big portion of dev mode gizmos was tested as well.
Additional info:
TradeRequestCompsync worker is not needed, as it's a subtype ofWorldObjectCompand we have an implicit sync worker for itCompToxifierneeded to be synced as it would cause infinite loop otherwise (it would keep syncing commands infinitely)Hediff_DeathRefusaltransforms a field of typeCommand_ActionWithLimitedUseCount.Building_BlastingCharge:Command_Detonatesyncing was removed, and instead synced throughCompExplosive.StartWickBlueprint_Build.ChangeStyleOfAllSelectedwon't be synced if nothing is selected, just as a precautionCompFlickable) - this is due to the comments to match their starting position, like how it was beforeUnfinishedThing