Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a broader Miri stub to test more of the code for UB #715

Open
nicholasbishop opened this issue Mar 26, 2023 · 0 comments
Open
Assignees

Comments

@nicholasbishop
Copy link
Member

Right now our Miri coverage is pretty limited since most of uefi requires interacting with the UEFI environment. There's a solution though, which is to create stubs for that environment. We do a small version of this in the file tests: https://github.com/rust-osdev/uefi-rs/blob/main/uefi/src/proto/media/file/mod.rs#L447

I've been experimenting on and off with doing this more broadly, and it has helped me find various problems that I've already submitted fixes for. I'm hoping it will also help give us confidence around issues like #685; we can't know exactly what a real UEFI implementation does in all cases, so we can never be 100% sure that Rust's abstract machine isn't being violated in some way, but I think with a sensible stub implementation we can get closer.

For now I don't have code that's even close to being PR-able yet, but filing this as a tracking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant