Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic ping when certain patterns occur in the diff? #1851

Open
RalfJung opened this issue Nov 1, 2024 · 0 comments
Open

Automatic ping when certain patterns occur in the diff? #1851

RalfJung opened this issue Nov 1, 2024 · 0 comments

Comments

@RalfJung
Copy link
Member

RalfJung commented Nov 1, 2024

The #[rustc_allow_const_fn_unstable] attribute should only be added with wg-const-eval approval. However, it hard to ensure that all reviewers know about this, and it is easy for a reviewer to miss this even if they are generally aware of this policy.

So could we get some bot help for that? If a PR adds new occurrences of this attribute, can we get an automatic ping from rustbot? Ideally, PRs removing the attribute wouldn't trigger the ping. So only lines with a + in the diff should be considered. Also, it might be worth restricting this to the part of the diff that is inside the library/ folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant