Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #10069 from Turbo87/publish-stream" #10102

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 28, 2024

This reverts PR #10069 and resolves #10098.

The 503 error returned by Heroku is apparently caused by our usage of the "legacy router" on Heroku. When using "Heroku Router 2.0" the 503 error is gone, but now AWS Cloudfront starts acting up and returns 500 errors instead.

From the looks of it this appears to be a bug in Cloudfront, which does not seem to be able to handle HTTP responses while the request hasn't fully been received yet?

Unfortunately, that means we have to revert the semi-streaming publish endpoint for now and buffer everything upfront again until we either figure out how to make this work in Cloudfront, or switch to a different CDN for the crates.io API.

@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-backend ⚙️ labels Nov 28, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) November 28, 2024 16:42
@Turbo87 Turbo87 merged commit 4f55cbe into rust-lang:main Nov 28, 2024
8 checks passed
@Turbo87 Turbo87 deleted the revert-stream-publish branch November 28, 2024 16:53
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (a27a914) to head (baa3411).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10102      +/-   ##
==========================================
- Coverage   89.47%   89.47%   -0.01%     
==========================================
  Files         294      294              
  Lines       31254    31224      -30     
==========================================
- Hits        27964    27937      -27     
+ Misses       3290     3287       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

503 on publishing a crate
1 participant