Skip to content

Commit

Permalink
Merge pull request #10095 from Turbo87/outdated-comments
Browse files Browse the repository at this point in the history
Remove outdated code comments
  • Loading branch information
Turbo87 authored Nov 28, 2024
2 parents 8b73b26 + 59f681d commit ec834ae
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
4 changes: 0 additions & 4 deletions src/controllers/krate/publish.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@ const MAX_DESCRIPTION_LENGTH: usize = 1000;
/// Handles the `PUT /crates/new` route.
/// Used by `cargo publish` to publish a new crate or to publish a new version of an
/// existing crate.
///
/// Currently blocks the HTTP thread, perhaps some function calls can spawn new
/// threads and return completion or error through other methods a `cargo publish
/// --status` command, via crates.io's front end, or email.
pub async fn publish(app: AppState, req: Parts, body: Body) -> AppResult<Json<GoodCrate>> {
let stream = body.into_data_stream();
let stream = stream.map_err(|err| std::io::Error::new(std::io::ErrorKind::Other, err));
Expand Down
2 changes: 0 additions & 2 deletions src/worker/jobs/send_publish_notifications.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ impl BackgroundJob for SendPublishNotificationsJob {
return Ok(());
}

// Sending emails is currently a blocking operation, so we have to use
// `spawn_blocking()` to run it in a separate thread.
let mut results = Vec::with_capacity(recipients.len());

for (ref recipient, email_address) in recipients {
Expand Down

0 comments on commit ec834ae

Please sign in to comment.