Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out automation of the "all" team on GH #768

Open
jamesmunns opened this issue Jun 19, 2024 · 3 comments
Open

Figure out automation of the "all" team on GH #768

jamesmunns opened this issue Jun 19, 2024 · 3 comments

Comments

@jamesmunns
Copy link
Member

We have a team, "all", that is not managed by the rust-lang teams bots.

Screenshot 2024-06-19 at 10 33 24

All other teams have a toml that has a section like this:

[[github]]
orgs = ["rust-embedded"]
team-name = "resources"

If we want the bot to manage the team access for the "all" account, I think we either need to:

  • add a wg-embedded-all.toml manifest to the rust-lang-team/teams folder: https://github.com/rust-lang/team/tree/master/teams
  • Add the [[github]] metadata to the wg-embedded.toml manifest, treating it as the source for the "all" team.
  • Get rid of the all team, as it's manually maintained atm

CC @therealprof, who I THINK set this all up originally. I'm not familiar enough with teams automation to know which option is right, but this came up with thejpster retiring.

@BartMassey
Copy link
Member

Option 4: Construct the all team as the union of the team manifests in CI. Optionally check to ensure that this matches the [[github]] manifest.

Or is the [[github]] manifest already this?

@jamesmunns
Copy link
Member Author

@BartMassey looking at the toml docs: https://github.com/rust-lang/team/blob/master/docs/toml-schema.md

It appears we could instead:

  • remove all people.members of wg-embeded.toml
  • add a people.included-teams section, listing all substeams
  • add the [[github]] section as proposed above

@jamesmunns
Copy link
Member Author

We should also add website.zulip-stream while we are at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants