Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release with rust-bitcoin 0.29 #452

Closed
josediegorobles opened this issue Aug 8, 2022 · 13 comments
Closed

New release with rust-bitcoin 0.29 #452

josediegorobles opened this issue Aug 8, 2022 · 13 comments

Comments

@josediegorobles
Copy link

Hi, rust-bitcoin 0.29 is released yet, when is planned a new release of rust-miniscript with this version?

@tcharding
Copy link
Member

No plans around here, its chaos mode :) I'm guessing soon as someone does the patch to upgrade the dependency. I'll try get to it today unless someone beats me to it.

@tcharding
Copy link
Member

FYI the following crates have to upgrade before we can upgrade rust-miniscript

And latter requires the former to be released first.

@josediegorobles
Copy link
Author

FYI the following crates have to upgrade before we can upgrade rust-miniscript

And latter requires the former to be released first.

Ok, first is done yet, is turn now of bitcoind (this issue: rust-bitcoin/bitcoind#82)

@josediegorobles
Copy link
Author

Hi, now all the others are done, isn't it? What's the state of this issue?

@josediegorobles
Copy link
Author

It's this PR: #450

@tcharding
Copy link
Member

That's the bitcoin upgrade, I don't know what else is to be done but there will be a release PR as well, that hasn't been done yet. You can do the release PR if you are keen, means writing release notes and bumping the version. Here are some examples

@josediegorobles
Copy link
Author

Ok I can see it

@josediegorobles
Copy link
Author

Hi @tcharding i made a PR: tcharding#1
I put 7.1.0 version and the bump version on the CHANGELOG. ¿It's correct the version? ¿What other things must be in the CHANGELOG?

@sanket1729
Copy link
Member

sanket1729 commented Sep 19, 2022

Sorry for the delay in my response.
@josediegorobles, your work looks great. In particular, for release PRs, I think it is best if the changelog PRs are made by maintainers. I made a draft PR for release #462

@tcharding
Copy link
Member

I think it is best if the changelog PRs are made by maintainers.

Oh sorry, that was my fault then - I thought you might be busy and going through all the previous PRs is kinda tedious. I'll keep this in mind in future.

@josediegorobles
Copy link
Author

The new release is with this draft PR: #462

@sanket1729
Copy link
Member

Oh sorry, that was my fault then - I thought you might be busy and going through all the previous PRs is kinda tedious. I'll keep this in mind in future.

No worries. Sorry for the effort you and Jose put in :(. It's not a hard rule that maintainers must create a changelog, but mostly they have a good idea of which changes are important to highlight.

@josediegorobles
Copy link
Author

Oh sorry, that was my fault then - I thought you might be busy and going through all the previous PRs is kinda tedious. I'll keep this in mind in future.

No worries. Sorry for the effort you and Jose put in :(. It's not a hard rule that maintainers must create a changelog, but mostly they have a good idea of which changes are important to highlight.

It's very reasonable to do it like that. No worries, and thank you all for your effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants