Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vcpkg #27

Closed
wants to merge 1 commit into from
Closed

Conversation

asuper0
Copy link

@asuper0 asuper0 commented Aug 9, 2022

No description provided.

Copy link
Member

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Just some little changes and a question:

  • Run clippy to fix all lints
  • Add a vcpkg feature

opus-sys/build.rs Show resolved Hide resolved
@lu-zero
Copy link
Member

lu-zero commented Aug 15, 2022

I wonder if wouldn't be simpler for you just provide the support in systemdeps directly.

@lu-zero
Copy link
Member

lu-zero commented Aug 15, 2022

Maybe contributing to mcgoo/vcpkg-rs#41 is a bit roundabout but looks like we are already to have support for it in system-deps itself.

@Luni-4
Copy link
Member

Luni-4 commented Aug 19, 2022

@asuper0

Could you update this PR as rust-av/examples#29?

@Luni-4
Copy link
Member

Luni-4 commented Aug 22, 2022

Closed for 9f04ec1

@Luni-4 Luni-4 closed this Aug 22, 2022
@asuper0 asuper0 deleted the support_vcpkg_win branch August 29, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants