Recognise ==Int and ==K equations as substitutions when internalising #4061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only matches ==Int and ==K. We could also match notBool (_ =/=Int _) and notBool (_ =/=K _) (more magic). When internalising rules and equations, the substitution must be turned back into predicates for the `requires` clause. Currently we also turn back the ensures clause substitutions into predicates (might want to change that).
|
No significant difference in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Booster now recognises predicates of shape
true #Equals (VAR ==Int <expr>)andtrue #Equals (VAR ==K <expr>)as substitutions (given the global scope does not contradict that, i.e., no cycles or multiple substitutions for the same VAR...).Currently only matches ==Int and ==K.
We could also match notBool (_ =/=Int ) and notBool ( =/=K _) (more magic).
When internalising rules and equations, the substitution must be turned back into predicates for the
requiresclause. Currently we also turn back the ensures clause substitutions into predicates (might want to change that).Part of #4059