Fix failures in iOS 9 #483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appear to be some changes in the recent Rubymotion updates (I haven't been able to find where) that means some specs were failing when run with iOS 9 as the target. This change introduces a fix specifically to the `Constants.get` method as used by `UIActivityViewController`. The error was, passing activities to exclude from the activity view caused an error where an Array was expected but the splat wasn't creating one. The other issue this fixes is to delegate the `tag` property on a `UINavigationViewItem` to it's child `UIBarButtonItem` in the test implementation (a `UINavigationViewItem` doesn't have a `tag` property).
felixclack
force-pushed
the
ios-9-spec-fixes
branch
from
451d536
to
60dec67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appear to be some changes in the recent Rubymotion updates (I
haven't been able to find where) that means some specs were failing when
run with iOS 9 as the target.
This change introduces a fix specifically to the
Constants.getmethodas used by
UIActivityViewController.The error was, passing activities to exclude from the activity view
caused an error where an Array was expected but the splat wasn't
creating one.
The other issue this fixes is to delegate the
tagproperty on aUINavigationViewItemto it's childUIBarButtonItemin the testimplementation (a
UINavigationViewItemdoesn't have atagproperty).