Port pcre dependency to pcre2 #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rsyslog#366 Upstream stopped the support for the old 'pcre' package. See https://www.pcre.org/ It only supports the new 'pcre2' version, we should replace the current pcre with the newer pcre2.
|
Some checks might complain about the presence of pcre2 but that is expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream stopped the support for the old 'pcre' package. See https://www.pcre.org/
It only supports the new 'pcre2' version, we should replace the current pcre with the newer pcre2.
I know that for various reasons it's not recommended to use regex but some years ago it has been enabled and shipped in Fedora, so we would like to further maintain it.
Fixes #366
Let me know what you think. If you feel like I can add a configuration option be able to specify which version of pcre you want to compile with. Thanks.