NameValueList new parameter : ignore_whitespaces #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I propose to add a new option to the "name-value-list" object for liblognorm V2 : ignore_whitespaces
The purpose of this option is to ignore spaces at the beginning and the end of keys and values.
Default behavior is not affected.
Old behavior
Historically, every caracters, even spaces, that are before and after separator and assignator are captured by name-value-list type.
For example :
Using the following rule :
the following string :
a: b, c: d
will give the following result :
Note the presence of spaces in front of the value " b" and the key " c".
This can lead to issues when we want to use those variables afterwards.
New behavior
With the use of
ignore_whitespaces
option, all spaces around keys and values will be trimmed.For example :
Using the following rule :
the following string :
a: b, c: d
will give the following result :
Good to know
Default and historic behavior does not change. This is a new option.
Spaces are not trimmed for quoted keys and values.